Feat/restart parent #6799
Merged
Feat/restart parent #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
feat/restart-parent
branch
4 times, most recently
from
604c6a7 to
46396fa
Compare
Breaking changeWhen the status of a task is changed from the Gantt -> Task Run -> Change state link, it will now restart the parent flow if any. |
loicmathieu
force-pushed
the
feat/restart-parent
branch
2 times, most recently
from
00f535c to
630d36a
Compare
loicmathieu
force-pushed
the
feat/restart-parent
branch
5 times, most recently
from
5303d98 to
e3accb5
Compare
loicmathieu
force-pushed
the
feat/restart-parent
branch
from
e3accb5 to
6e93360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to restart a parent execution when we change the status of a subflow execution task that fail (which restart the subflow execution).
It was not the case before because a parent execution is notified of subflow execution thanks to the subflow execution storage (a table in JDBC and a store in Kafka) which is deleted when the subflow execution ends. So when a subflow execution restart, there are no more subflow execution inside the storage and the parent is never notified again.
Th implementation was changed so the subflow execution storage is no longer needed, we use the information of the execution trigger to know that we need to notify a parent flow so it can be restarted.
The underlying table is not deleted to avoid potential issues during migration; a follow-up issue will be created so the table will be removed in 0.22.
The PR also introduced some small changes to improve change state and restart:
system.restarted: truesystem labelFixes #6722